Skip to content
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

Allow renaming cluster, host, and storage#608

Merged
yadvr merged 2 commits intoapache:masterfrom
PCextreme:rename-host-storage-cluster
Aug 26, 2020
Merged

Allow renaming cluster, host, and storage#608
yadvr merged 2 commits intoapache:masterfrom
PCextreme:rename-host-storage-cluster

Conversation

@GabrielBrascher
Copy link
Member

@GabrielBrascher GabrielBrascher commented Aug 24, 2020

Description

Current CloudStack master (4.15.0.0-SNAPSHOT) API commands updateHost, updateCluster, and updateStoragePool allow updating the respective resource name.

This PR adds support for such edit buttons on CloudStack primate.
CloudStack PR: apache/cloudstack#4165

Screenshots

Update Host name:
image

Update Cluster name:
image

Update Storage name:
image

@GabrielBrascher GabrielBrascher added the enhancement New feature or request label Aug 24, 2020
@GabrielBrascher GabrielBrascher self-assigned this Aug 24, 2020
@davidjumani
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/608 (JID-3355)

@davidjumani
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/608 (JID-3358)

@davidjumani
Copy link
Contributor

@GabrielBrascher Could you change label.clustername in en.json to Cluster Name

Copy link
Contributor

@davidjumani davidjumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking on primate QA, but tested locally. Working fine!

@davidjumani
Copy link
Contributor

@rhtyd Good to go!

@GabrielBrascher
Copy link
Member Author

@davidjumani thanks for the review. I pushed a commit changing clustername.label from Cluster to Cluster Name.

@GabrielBrascher
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@GabrielBrascher a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/608 (JID-3363)

@davidjumani
Copy link
Contributor

Thanks @GabrielBrascher
@rhtyd Good to go!

@yadvr yadvr added this to the 1.0-GA milestone Aug 25, 2020
label: 'label.edit',
dataView: true,
args: ['tags', 'capacitybytes', 'capacityiops']
args: ['name', 'tags', 'capacitybytes', 'capacityiops']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidjumani how does it fare if mgmt server/API does not support the arg?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'll get passed but ignored by the backend, but yes, better add an ACS version check

@yadvr yadvr merged commit b4d3f56 into apache:master Aug 26, 2020
weizhouapache pushed a commit that referenced this pull request Jan 19, 2021
* Allow renaming cluster, host, and storage

CloudStack PR: apache/cloudstack#4165

* change clustername.label to Cluster Name
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants